New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: runtime-corejs 2 should depend on core-js@2 #14937
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52950/ |
(DependencyType = 'dependencies'), | ||
% The rule works for @babel/runtime-corejs2 only | ||
(WorkspaceIdent = '@babel/runtime-corejs2'). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now yarn constraints
will throw
YN0024: @babel/runtime-corejs2 must depend on core-js via ^2.6.12, but uses ^3.25.1 instead (in dependencies)
if we run yarn up core-js
without yarn constraints --fix
, the constraint check is in CI so we should be all good.
I'll release as soon as ci is green on main. |
Amazing, thanks! |
This fix does not yet appear to be pushed to NPM - is this a caching issue or did we fail to push the release? |
@mynnx https://www.npmjs.com/package/@babel/runtime-corejs2/v/7.19.2 This is a caching issue. |
This PR fixes a regression introduced in #14924: We run
yarn up core-js
without checking that@babel/runtime-corejs2
must depend oncore-js@2
. This issue had happened once before but then we fixed it before we published. Anyway I draft a new yarn constraint and hopefully it won't bother us any more.